Responsive landing page using flexbox

Community feedback

• Account deleted

  Looks good, nothing out of place that I can see.

  Keep coding.

  Marked as helpful

  3

  ---

  

  Diu Gach•145

  @DiuGachPosted over 3 years ago

  @thulanigamtee Thanks so much

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋Hi Diu Gach! My name is Vanza!

  I have some feedback on this solution:

  • You need to select font weight 400 and 600 for this project.
  • Don't change the html font size to 62.5%. It will make the user need to zoom a lot if the have a bad eye sight. Try to leave it as default which is font-size: 100%.
  • Instead of writing something like this on your html:

  <div class="descriptions">
          <div class="descriptions__desc">
            <h3 class="descriptions__desc descriptions__desc--h3">Quick Search</h3>
            <p class="descriptions__desc descriptions__desc--p">Easily search your snippets by content, category, web
              address, application, and more.</p>
          </div>
  </div>
  

  I recommend to change the class name into something like this, which is in my opinion it is much easier to understand:

  <div class="descriptions">
          <div class="descriptions__text">
            <h3 class="descriptions__heading">Quick Search</h3>
            <p class="descriptions__p">Easily search your snippets by content, category, web
              address, application, and more.</p>
          </div>
  </div>
  

  • Also make the .descriptions, text-align: center on mobile screen, since that's how it is on design.
  • Try to use text-align: left rather than text-align: start, since text-align: left, get Internet Explorer support. To see or learn more, check MDN web docs about text-align.

  That's it! Hopefully this is helpful!

  Happy Coding!

  Marked as helpful

  1

  ---

  

  Diu Gach•145

  @DiuGachPosted over 3 years ago

  @vanzasetia Wow what a marvelous feedback, I really appreciate your kind feedback, and I will do my best next time to improve on those points, thanks so much.

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  @DiuGach I would recommend that you fixed all the issues on this solution first and then moving on to do another project. It's simply because fixing bugs, it's one of the skill that you need as a developer.

  0
• Account deleted

  Hello DiuGach👋

  Congratulations on completing this challenge 🥳

  Your solution looks nice 👍

  • Wrap your social-media icons into anchor tag.

  • &__desc {

  //Change text align to (center)

      text-align: center;
  

  }// For mobile

  I've also completed this challenge you can checkout

  Marked as helpful

  1

  ---

  

  Diu Gach•145

  @DiuGachPosted over 3 years ago

  @Nik-web12 Wow thanks for your honest feedback bro:), I will definitely implement that (wrap social icons on <a> anchor tags) will see your solution too.

  0