Responsive landing page using flexbox

Community feedback

• 

  Foued•655

  @Foued80Posted over 3 years ago

  hi,

  1. the desktop view needs a container with a max-width of 1440px

  2. hovering over the nav links shift the content try to force border to 0 on the li's

  3. try the aspect-ration preperty to set the corect width/height of background images

  4. don't use duplicate IDs check your solution report and fix the problems

  Marked as helpful

  0

  ---

  

  Menna Rashad•90

  @Menna-RashadPosted over 3 years ago

  @Foued80 Thank you!

  1. does the container need to have a max-width of the viewport the challenge specifies? (here is 1440px like you mentioned), if yes, why is that?. and does it need to have a max width for mobile view too? (375px)
  2. I don't think it's the border issue tho (I think it's the font size cause I use another font for hover effect, I'll try to fix it)
  3. that property is new to me but I'll read about it, thank you for the suggestion.
  4. I didn't notice I made a duplicated id. My bad

  0

  

  Foued•655

  @Foued80Posted over 3 years ago

  @Menna-Rashad hi,

  The design image provided for desktop has width of 1440px full screen) and the solution's preview use that width to check between the design and your version

  For mobile i personaly start at 320 and switch to desktop at 576px

  0
• 

  Jordan•180

  @JSCHLTEPosted over 3 years ago

  You forgot to add the 3rd testimonial. Also some of the images aren't the correct widths and heights, but other than that the mobile view looks pretty good.

  Marked as helpful

  0

  ---

  

  Menna Rashad•90

  @Menna-RashadPosted over 3 years ago

  @JordanDevelops Thank you for the feedback! I don't know about the 3rd testimonial but I'm pretty sure I added it. the images at the bottom I think it's the testimonial's section issue (the height isn't correct yet)

  0

  

  Jordan•180

  @JSCHLTEPosted over 3 years ago

  @Menna-Rashad Yes I see the 3rd testimonial but you just forgot to change the profile picture for the 3rd one that's all. It has the same img as the first one.

  0

  

  Menna Rashad•90

  @Menna-RashadPosted over 3 years ago

  @JordanDevelops didn't notice that haha! Thank you.

  0