Design comparison
Solution retrospective
I would like to know which is the difference or pros between using Flex and using Grid in this specific project.
Thank you in advance for your answers.
Community feedback
- @pikapikamartPosted about 3 years ago
Hey, awesome work on this one. Layout in desktop looks great.
Well on this one, flexbox is more suited since for example, on the section of the pricing plan, it is only a one row layout which flexbox is good at, though you can use grid as well on that and it will be just one row ( for me ). I find it hard to tell pros and cons in here since the layout is not really a hard one though.
Some other suggestions would be:
- I wouldn't add a
min-width: 375px
on thebody
as there are lots of phones that the width is much smaller or the same as that. Removing that will be great so that the layout will really adapt. - Background-image of the wave is missing, you might want to check that one out.
- Good choice to use heading tag on the
annual-plan
but the heading level of choice is incorrect. It should have beenh2
and noth3
. Because you don't want to skip a level. If you useh3
make sure thath1, h2
are present "before" it. - The text below the annual-plan is not a heading at all , since it is the content that the heading tag (annual-plan) is referring to in the section. A
p
tag would be nice . - You don't have to add a text-element inside the
a
tag, just put the text directly as thea
tag's text-content. Removeh5
inside.
Aside from those, great job again on this one.
0 - I wouldn't add a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord