Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
This is my first project it is not perfect
What challenges did you encounter, and how did you overcome them?How to approach the project and responsive
What specific areas of your project would you like help with?responsive, media query
Community feedback
- @A-noob-in-CodingPosted 3 months ago
Hi there, you did a good job in this solution, however here are some things you used consider in your next project:
- For images use the figure semantic tag for better accessibility, you used to have a empy div and used the QR image as background instead:
In html
<figure> <img src = "qr-image"> </img> </figure>
In CSS:
img{ width: 100%; height:auto; display: block; }
In this way all you need to have this figure in a container and the image will resize automatically for a responsive desing, you would need to remove the default margin of the
<figure></figure>
elementAlso you are using an extra div for cover the full screen width, you could apply this to body instead of less lines of code
Hope it is helpful for you 🥰
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord