Responsive landing page using flexbox

Community feedback

• 

  Assurance Chioma Ikogwe•410

  @Aik-202Posted about 2 years ago

  Hi Walter, Nice work!!!!. I have some suggestions though

  1. Change the div tag with class container to main, as there must be a main tag in your html...
  2. You can change the button tag to a div and give it aria role "button", this will help fix the html issue. i.e <div role = "button"></div>
  3. Instead of using h1 tag for the striked price you can use the sup tag , it's used for superscripted text in html... and it can be embedded in the first h1 tag with class precio i.e <​h1​ ​class​="​precio​" ​> $149.99 <sup>149.98</sup> ​</​h1​>.. by doing this you will reduce the spacing between the two digits..

  Marked as helpful

  0

  ---

  

  Walter Contreras•40

  @ContrerasdevPosted about 2 years ago

  @Aik-202 Great, thanks, I'll make the corrections you told me. :)

  0

  

  Assurance Chioma Ikogwe•410

  @Aik-202Posted about 2 years ago

  @tomijos Okay, you are welcome. Glad to be of help.

  Marked as helpful

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  @Aik-202

  Using div with role="button" makes it gets pronounced as a button but at the same time, it doesn't make the div behaves like a real button element. You need to do more things to make sure that the div behaves like a button.

  @tomijos To fix the HTML issue all you need to do is to fix the typo (<botton class="btn">). It should be <button> instead of <botton>.

  Marked as helpful

  0

  

  Assurance Chioma Ikogwe•410

  @Aik-202Posted about 2 years ago

  @vanzasetia Ooh, my bad, I didn't notice it was a wrong spelling. I actually asked him to do that because the p tag is not allowed as a child of the button and since the button really isn't performing any function I told him to go with that approach, anyways I found a better approach on stack overflow. @tomijos even after correcting the spelling, change the <p> tag to <span> tag instead. here's the link to the approach I found on stack overflow.

  Marked as helpful

  1

  

  Walter Contreras•40

  @ContrerasdevPosted about 2 years ago

  @Aik-202 and @vanzasetia. Thank you for your help, I corrected what they told me, I am very grateful for the help. Thank you

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  @tomijos Great! I would recommend generating a new report to make sure there is no issue left.

  0

  

  Assurance Chioma Ikogwe•410

  @Aik-202Posted about 2 years ago

  @tomijos You are welcome, I'm glad I could be of help.

  0