Responsive landing page using flex box qr-code-component

Community feedback

• 

  Ahmed Bayoumi•6,740

  @Bayoumi-devPosted about 2 years ago

  Hey Tadem, Congratulations on completing this challenge... You have accessibility issues that need to fix.

  • Document should have one main landmark, Contain the component with <main>.

  <main>
     <div class="container">
        //...
     </div>
  </main>
  

  • Page should contain a level-one heading, Change h2 to h1 You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • All page content should be contained by landmarks, Contain the attribution with <footer>.

  <footer>
     <div class="attribution">
        //...
     </div>
  </footer>
  

  • I suggest you use REM for font size, It is a must for accessibility because px in some browsers doesn't resize when the browser settings are changed... See this article ---> CSS REM – What is REM in CSS?

  • Also, I suggest you look into an approach called "BEM" Block Element Modifier

  • How to Use Google Fonts in HTML and CSS

  Hope this help!... Keep coding👍

  0

  ---

  

  Tadem Rechal Shiny•10

  @shine2024Posted about 2 years ago

  @Bayoumi-dev Thank you 😊 i will correct it.definetly going to use this tips .

  0