Melvin Aguilar π§π»βπ»β’ 61,220
@MelvinAguilar
Posted
Hi @Julio-Freitas π, good job completing this challenge, and welcome to the Frontend Mentor Community! π
I like this solution for the challenge. I have some suggestions you might consider to improve your code:
- Use the
<main>
tag to wrap all the main content in your solution instead of using<div class="qrCode-container">
to improve the accessibility of the website.
- Additionally, you can use the
<article>
tag instead of div to the container card:<div class="qrCode-card">
.
- You should not name your class with the camelCase convention. Use naming naming conventions to name it.
- Always avoid skipping heading levels; Always start from
<h1>
, followed by<h2>
, and so on up to <h6> (<h1>,<h2>,...,<h6>).
- Use an h1 tag for your solution. The
<h1>
element is the main heading on a webpage, also, there should only be one<h1>
tag per page. Swap the<h3>
tag with<h1>
.
Above all, the project is done wellπ. I hope those tips will help you! π
Good job, and happy coding! π
Marked as helpful
1
Julio Cesarβ’ 130
@Julio-Freitas
Posted
Hi @MelvinAguilar! π Thank you for the tips =D. I will apply your suggestions in the project π
1