Responsive Landing page using Flex and Sass, and interactions using JS

Community feedback

• 

  Roc Tanweer•2,500

  @RocTanweerPosted over 3 years ago

  And about aria...

  You have used aria-describedby quite often but you may have got confused and did everything opposite of how it was suppose to be...

  Lemmi explain...

  Describedby simply mean something is described by something else

  When you put that aria on an element, then it will take the id of another element that is describing that element and you have been doing the opposite...

  A paragraph will describe a heading and not the opposite...So

  You should put aria-describedby="id of paragraph" on heading...

  Good luck

  You can visit MDN for more info

  1

  ---

  

  Francel•370

  @HaemoffyPosted over 3 years ago

  @RocTanweer Oh, probaby got confused of the word "by", I keep this wonderful explanation in mind, thank you very much for the response

  1
• 

  Roc Tanweer•2,500

  @RocTanweerPosted over 3 years ago

  Hello 👋

  Great work 👌 and quite extensive use of arias...

  I just reviewed you index.html file and it was really impressive..! I also made the same project but your work is too good...

  But I wish to point out some things...

  • In feature tab section, the tab changers are suppose to be buttons and not h tags... Because users are clicking on them and something is happening

  • When you put an icon in a link, you should put a span in the link with text describing the icon and adding sr-only class to that span. All these for accessibility purpose.

  <a><span class="sr-only">Facebook icon</span>icon here...</a>
  

  You can download sr-only class from Google...

  Hope it helps and happy coding 😉

  1

  ---

  

  Francel•370

  @HaemoffyPosted over 3 years ago

  @RocTanweer thank you very much for the feedback , i didnt know sr-only exists, this will definitely do a big help for my future projects

  1