Responsive landing page using flex

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hi kehinde oyafemi,

  Congratulation on completing this challenge. your solution looks great. I have some suggestions regarding your solution if you don’t mind:

  • You can use the <main> landmark to wrap the body content (which is the three cards).

  • In this challenge , as it’s not a whole page, you can have<h1>visually hidden with sr-only.

  • In my opinion, the images are much likely to be decorative. For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images.

  • Interactive controls must not be nested. What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.

  • Consider including a git ignore. Less important in this challenge but will become extremely important as you move onto larger projects with build steps Hopefully this feedback helps

  0

  ---

  

  kehinde oyafemi•190

  @kennyoyafPosted about 2 years ago

  @PhoenixDev22 thank you so much for your observations will take note

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @kennyoyaf Happy coding!

  0