Design comparison
Solution retrospective
this was intresting task for me I done this challenge after just completing my MTE, almost after 20/days break and completed in a day i am happy for this. anyone who want to suggest any thing just add comment
Community feedback
- @devaramnyePosted about 1 year ago
Great work there,
I recommend you getting rid of div's, instead use landmarks. As example you declared your first div inside your body with an attribute of class with the value of main. You could instead create a <main> landmark which contains the main content of your page. It give a better HTML structure / readability.
And you missed this part:
- View the optimal layout depending on their device's screen size
You can reach the goal by working with media queries and for the image to be responsive, you can use the element picture to have an integrated media query inside your HTML for your image. This project has two different image sizes for depending device.
You can find the information's of media queries and the element picture on the internet. And you need some more information's about responsibility, you can give yourself a little peek to kevin powells 21 day challange which is for free. It gives a huge knowledge area for your future work with CSS.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord