Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
The “Illustrations” serve no other purpose than to** be decorative**; They add no value. Their
Alt Tag
should left blank and have anaria-hidden=“true”
to hides it from assistive technology. -
The
Article
element is not the best choice for wrapping your sections. In order to use theArticle
element the component needs to be able to **make sense on its own and be independently distributable (can be used in on another site).
The
footer
links need to be wrapped inside anav
element-
The “social media icons” are not decorative, they need to have an
Alt Tag
with a description. -
Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord