Responsive Landing Page Using CSS grid

Community feedback

• 

  Naveen CB•420

  @Naveen-CBPosted 10 months ago

  Hello @ofaruqayo

  First of all let's speak about your solution, that is looking good and also matches close to the solution.

  But I have some suggestion that take your coding and upcoming project to next level.

  I have noticed four issue ** Two for CSS and Two for HTML.**

  About CSS📌

  1. you are not yet centered your container so try this to center it

                           .container{
                                 display: grid;
                                 min-height: 100vh;
                                 place-content: center;
                                  place-item: center;
     

  2. It always a best practice to use rem or em instead of using pixels except you only need just few pixels of white spacing.

  About HTML 📌

  1. Adding <main></main> is always improves SEO and also accessibility of web so try to include main to your code.

  2. Semantic HTML plays a major role so instead of writing <div class= "card item2"> try to use <article class="card item2"> and same for all other card items.

  Overall try to use simple and more accessible mark up.

  I hope this might be helpful to you❤️.

  0