@TedJenkler
Posted
Hi @maziarja,
Great job on the project! I like the work you’ve done. I did notice a couple of issues:
There seems to be a bug with the background in your project on my laptop but when I inspect in Chrome dev tools it works.
The + and - buttons in the top-left corner might be unnecessary and break ur responsiveness, so consider removing them.
The zoom functionality feels a bit too sensitive; adjusting it could improve the user experience.
I tried to find the code on GitHub, but it looks like the repository isn’t available at the moment. Despite that, the overall project is impressive. I hope this feedback helps!
Best regards, Teodor
Marked as helpful
@maziarja
Posted
@TedJenkler thank you for your helpful comment, because of the API key I had to private this project on Git Hub. Also, I removed the + and - buttons, hope it works better,
@TedJenkler
Posted
@maziarja
*(https://www.dotenv.org/docs/)
It’s definitely working better now! For future projects, especially if you work on something more advanced like the flag project, I recommend using .env files and .gitignore to manage and hide your API keys. Deploying on Netlify with environment variables is usually easier to configure compared to GitHub Pages, where setting up environment variables can be quite complex(For me at least).
I hope this tip helps!
Marked as helpful
@maziarja
Posted
@TedJenkler thank you for letting me know about dotenv, I hide my API_KEY using .env and gitignore. The project is public on GitHub now.
