Responsive landing page using CSS grid, flexbox & Vanila Js

Community feedback

• 

  Benjo Quilario•1,810

  @benjoquilarioPosted almost 3 years ago

  Hi Nasim Reja

  You did a great job on this one. It looks good and response rather well.

  Some suggestion to fix your A11y or ACCESSIBILITY ISSUES to ensure that all link names are accessible you need to add the aria-label on your logo defining where the link would take them. Eg. <a href="#section1" style="width: 17rem;" aria-label="Bookmark - Home Page">

  As for the email validation you can add this on your script file.

  form.addEventListerner('submit', function(e) {
      e.preventDefault();
      const email = document.querySelector('#email');
     let re = /^([a-z\d\.-]+)@([a-z\d-]+)\.([a-z]{2,8})(\.[a-z]{2,8})?$/;
  
     if (re.test(email.value)) { // Will check if there a value of the re variable
        success.classList.add('success');
     } else {
       success.classList.remove('success');
     }
  })
  

  Keep coding and Good Luck!

  1

  ---

  

  Nasim Reja•220

  @nasim67rejaPosted almost 3 years ago

  @benjoquilario Thanks man.it's really helpful 😊

  0
• 

  optimusprime202•1,200

  @optimusprime202Posted almost 3 years ago

  Hey @nasim67reja, I knew you could do it.

  1
• 

  Lucas Bargas•0

  @LucasBargasPosted almost 3 years ago

  Congrats! But the mobile menu can be 'position: fixed' and close when click on the links.

  0

  ---

  

  Nasim Reja•220

  @nasim67rejaPosted almost 3 years ago

  @LucasBargas yeah . Thanks for your feedback

  0