Responsive landing page using css grid, flex and sass

Community feedback

• 

  Adriano•38,040

  @AdrianoEscarabotePosted almost 2 years ago

  Hello Leela, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  I noticed that you used a button in which case the best option would be an a, because in my head when a person clicks on a button written Read more, he is not confirming a form, or something like, it will be redirected to another page, to read more about!

  to solve this problem do this:

  <a href="/" class="button">Read more</a>

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem! link -> px to rem

  The remainder is excellent.

  I hope it's useful. 👍

  0

  ---

  

  Leela•30

  @vlpreddyPosted almost 2 years ago

  @AdrianoEscarabote

  I totally missed about button it should be link for better accessibility as well, I will fix this issue quickly.

  I will try to use rem from now onwards, it makes sense, i did used this unit in live projects but didn't think through all this, I guess i need to read about the units a little bit, thanks for the advice.

  1

  

  Adriano•38,040

  @AdrianoEscarabotePosted almost 2 years ago

  @vlpreddy happy coding!!

  0
• 

  J Z•290

  @half-ctoPosted almost 2 years ago

  Hi Leela, great work on completing challenge.

  Regarding media queries, I like to set up a mixin like this one

  @mixin desktop {
      @media screen and (min-width: $desktop-size) {
          @content;
      }
  }
  

  and use it inside element I'm changing, I find it keeps clean structure and is easy to troubleshoot.

  0

  ---

  

  Leela•30

  @vlpreddyPosted almost 2 years ago

  @half-cto

  I think this is one of smart way of using mixin. Is there any difference between using inside element itself and using inside it's parent element?

  0

  

  J Z•290

  @half-ctoPosted almost 2 years ago

  @vlpreddy I'm using query inside element, I find it keeps file more organized.

  0
• 

  daniel mendoza•140

  @JdanielmendozaPosted almost 2 years ago

  esta genial..

  0

  ---

  

  Leela•30

  @vlpreddyPosted almost 2 years ago

  @Jdanielmendoza

  Thanks Daniel..!

  0