Responsive landing page using CSS grid

Community feedback

• 

  Vishal Maurya•500

  @VishalMauryastpPosted over 1 year ago

  Hi, You tried well , but it's a Single price grid component so ,I think you should use display:grid property to make this design .

  • You need to fix the **width ** of main <div> and fix the height of main <div> as **min-height: ; **.

  • If you are using display:flex ** ,then you need to fix width of ** bottom <div>. -if you are using display:grid ,then use this code .

  .bottom{
            display: grid;
          grid-template-columns: repeat(auto-fit, minmax(310px, 1fr));
  }
  
  .left,right{
              min-height: 259px;
              padding: 41px;
  }
  

  I hope ,it's helpful for you 😐.

  Marked as helpful

  0
• 

  Hassia Issah•50,670

  @HassiaiPosted over 1 year ago

  Replace <div class="container"> with the main tag and wrap Join our community in <h1> <h1>Join our community</h1> to make the content/page accessible. click here for more on web-accessibility and semantic html

  There is no need to give the body a margin value.

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  To center .container on the page using flexbox or grid instead of margin,

  • USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID: add min-height:100vh; display: grid place-items: center to the body

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  For a responsive content give .container a fixed max-width value instead of a percentage width value. max-width: 600px . you dont have to change this value in the media query.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  Jurdel Gallano•380

  @secretcrew2Posted over 1 year ago

  Great job on completing this challenge!

  One recommendation I have is to use a max-width:800px instead of width: 100% for the container. Additionally, for the body, it's better to add padding instead of margin so it will looks good on mobile devices.

  Marked as helpful

  0