Responsive landing page using CSS Grid and Flexbox
Design comparison
Solution retrospective
I would really appreciate a feedback on my code. Thanks!
Community feedback
- @NaveenGumastePosted over 2 years ago
Hello Mateja Cimperšak ! Congo 👏 on completing this challenge
Let's look at some of your issues, shall we:
-
Always use
h1
first for the heading and thenh2
,h3
and so on , do not use p -
Add Main tag after body
<main class="container"></main>
happy Coding😀
Marked as helpful1 -
- @willettoPosted over 2 years ago
I just submitted mine and was looking for other projects to see how they did it. I think yours looks great. The first thing I noticed when previewing your site is the @media query size was really large. It actually loaded in mobile for me, even though my browser was over 1000px across. Maybe bump it down to 900?
Marked as helpful1 - @shashreesamuelPosted over 2 years ago
Excellent work with this challenge, try renaming
div class="container"
to ```main class="container" to fix your accessibility issues.Cheers, Happy coding
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord