Responsive landing page using CSS Grid and flex-box

Community feedback

• 

  Adarsh•1,640

  @adram3l3chPosted almost 3 years ago

  The gap is caused by the margin of h2 tag. you have to set that to 0 to get rid of the gap

  Marked as helpful

  1

  ---

  

  Leah Thompson•30

  @leahthompson01Posted almost 3 years ago

  @adram3l3ch Thank you, this fixed it! I was confused because I knew I didn't set a margin to my h2 elements, but I didn't think about how it already has a margin.

  1

  

  Adarsh•1,640

  @adram3l3chPosted almost 3 years ago

  @leahthompson01 every element tag in html have its own margin and paddings. A reset in the beginning could avoid the confusion

  *,*::After,*::before{
    margin:0;
    padding:0;
    box-sizing:border-box;
  }
  

  0
• 

  Florin.Porut•380

  @zastar23Posted almost 3 years ago

  Hello, to get rid of the space between the name and the verify graduate, just change the line-height in the div containing them and you should be good to go.

  Overall nice job done!

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Leah, great work and congrats on completing the challenge!

  use a div for the body of the card and not section... section is suitable for page sections, read here -> Section use

  Also don't forget to look at the report issues.

  Overall you did well, keep it up!

  Happy coding!

  0