Skip to content
Submitted about 1 year ago

Responsive landing page using CSS Grid

keeran_kb•10
@keerankb
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I will be glad, if I get any feedback over this solution, and suggestions are always welcome, especially related to coding standards.

Community feedback

  • John Schlesinger•280
    @Jschles1Posted about 1 year ago

    Hey Kiran,

    Great job completing this challenge. The only thing that sticks out to me is that the font size is set in px. Ideally we should be setting the font size using rem for accessibility reasons.

    See more here

    Marked as helpful
    1
    keeran_kb•10
    @keerankbPosted about 1 year ago

    Thanks & Noted, going forward will catch up!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord