Responsive Landing Page using CSS Grid

Community feedback

• 

  Prince Roy•1,210

  @iprinceroyyPosted over 2 years ago

  Hey @hanzlasaadi, Great work. You need to focus on some points here:

  1. Don't use h1 multiple times, there can be only one h1 through the web page.
  2. Those avatar images with title, you can use figure & figcaption tag for that figcaption.
  3. Use the blockquote tag for quotes text.
  4. span is an inline tag, it can't be used as a block tag. Use div for the block.
  5. Increase the padding of the container to match with provided design. .container{padding: 5rem; }
  6. Use relative unit instead of px unit. 1rem = 16px.

  Hope it adds to your learning. Happy coding :)

  Marked as helpful

  1

  ---

  

  Hanzla•30

  @hanzlasaadiPosted over 2 years ago

  @iprinceroyy Thanks for the tips. I updated my repo with your suggestions☺. I was having problems with naming headers containing the figure and the names, so I tried to use the span for its inline property but didn't work so I kinda left it there because it was working😁. Thanks BTW

  0