Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive landing page using CSS Grid

@chrischakrit

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback/comments are highly appreciated. Thanks you.

Community feedback

Vanza Setia 27,795

@vanzasetia

Posted

Greetings, Chris! 👋

Congratulations on finishing this challenge! 🎉

I have some feedback on this solution:

  • Accessibility
    • Well done on using landmarks! 👍
    • Don't use article for the card content since it is not a full webpage. This is one chunk of content that all belong together and in a real website would sit with other content. In this case, div would be fine.
    • <div id="sub-2">$29 <span id="sub-3">per month</span></div> Always wrap text content with meaningful element like p element in this case. Only use div and span for styling purposes.
    • Also, I would recommend using the $ (dollar sign) instead of using character entity reference. The UTF-8 character set supports all symbols and even emojis.
    • The Sign-up button should be either a link or button element, depending on what do you think is going to happen after the user clicks it. It's definitely not a submit input.
    • For your information, input with type="submit" is a browser legacy. Use button with type="submit instead.
    • Don't use br elements for presentational purposes. Read what MDN documentation says about it.
    • For the why us section, I would recommend making it as a ul and wrapping each item with li.
  • Best Practice (Recommended)
    • Always use classes to reference all the elements that you want to style. Using id is going to make your stylesheet have high specificity (hard to maintain).

That's it! Hopefully, this is helpful! 😁

Marked as helpful

1

@chrischakrit

Posted

@vanzasetia Thanks so much, very appreciated your feedback. For new learner like me, it is so valuable and insightful which only can be gained from real world experience. I really love this community that give me countless opportunities to connect and get feedback from experienced professional devs.

1
Vanza Setia 27,795

@vanzasetia

Posted

@chrischakrit No problem! Glad to help! 😃

0
MatiX 360

@MatiX221

Posted

Good. But <article> should have <h1-6> tag. If it doesn't just use <div>

You're using article:first-child but why, just use <article class="community">

.grid-container has <width: 36%>, but you can just set value like 30em and if you worry you can set max-width:80%

Marked as helpful

1

@chrischakrit

Posted

@MatiX221 Thanks, love your feedback. I will check this out and improve my code.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord