@vanzasetia
Posted
Greetings, Chris! 👋
Congratulations on finishing this challenge! 🎉
I have some feedback on this solution:
- Accessibility
- Well done on using landmarks! 👍
- Don't use
article
for the card content since it is not a full webpage. This is one chunk of content that all belong together and in a real website would sit with other content. In this case,div
would be fine. <div id="sub-2">$29 <span id="sub-3">per month</span></div>
Always wrap text content with meaningful element likep
element in this case. Only usediv
andspan
for styling purposes.- Also, I would recommend using the $ (dollar sign) instead of using character entity reference. The UTF-8 character set supports all symbols and even emojis.
- The Sign-up button should be either a link or button element, depending on what do you think is going to happen after the user clicks it. It's definitely not a submit
input
. - For your information,
input
withtype="submit"
is a browser legacy. Usebutton
withtype="submit
instead. - Don't use
br
elements for presentational purposes. Read what MDN documentation says about it. - For the why us section, I would recommend making it as a
ul
and wrapping each item withli
.
- Best Practice (Recommended)
- Always use classes to reference all the elements that you want to style. Using
id
is going to make your stylesheet have high specificity (hard to maintain).
- Always use classes to reference all the elements that you want to style. Using
That's it! Hopefully, this is helpful! 😁
Marked as helpful
@chrischakrit
Posted
@vanzasetia Thanks so much, very appreciated your feedback. For new learner like me, it is so valuable and insightful which only can be gained from real world experience. I really love this community that give me countless opportunities to connect and get feedback from experienced professional devs.
@vanzasetia
Posted
@chrischakrit No problem! Glad to help! 😃