Responsive landing page using CSS Grid

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @SpacemanOG, some suggestions to improve you code:

  • For this challenge you want to use the Picture Element not the Background Image Property. The Background Image Property is mainly used on decorative images

  Picture Element will allow your to switch between images in different breakpoints and makes your site load faster by saving bandwidth.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • The name of the perfume , “Gabrielle Essence Eau De Parfum” is the most important content in your card so it should be wrapped in a Heading Element.

  • The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  spacemanOG•120

  @SpacemanOGPosted about 2 years ago

  @vcarames That's some very useful feedback, dear friend!

  🔷 I learned about the PICTURE tag previously but did not fully understand the application till now. I will change it asap and will follow the guideline in the future.

  🔷 Changed the name of the perfume to H1.

  🔷 Added the DEL tag, and the SR-ONLY part like this: <span class="sr-only">The old price is</span><del>$169.99</del>

  🔷 I will be following the Mobile-first development principle from now on!

  QUICK QUESTION ❓While making the changes you suggested, I noticed that I put the contents inside DIVs, without any P tags. Do you think that's a good thing? Or should I practice putting content inside P tags?

  Once again, many many thanks for taking the time to share those feedback ⭐🙏

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  @SpacemanOG

  Glad I could help!

  Flip the Del tag and the span. Del on the outside and span inside.

  Regarding the div, it is fine. There are no rules stating that you need a paragraph element, when it is the only content inside.

  If there was more content, then yes, would need the paragraph element.

  Marked as helpful

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @SpacemanOG, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  0