Responsive Landing page using CSS flexbox

Community feedback

• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hello Divine, congrats on finishing the challenge, good job!

  If you don't mind I would like to give you some feedback!

  • I would recommend you to use a separate CSS file for your styles, instead of styling everything in your index.html, it will make your code more readable, clear and easy to change!, you just need to create a separate styles.css file, and link it using <link rel="stylesheet" href="the path to your css file">

  • It seems that you forgot to add the fonts on your project cause it's using the default sans_serif font!, try adding your font directly into your head tag. You can get your desired font on google-fonts.

  • Try using some more semantic html tags like header, main, section and article! it will improve a lot the accesibility to your page.

  • Good job with your media querie for mobile, if you want to center all the items instead of having them on the left, use flex in your .container class!

  .container {
    justify-content: center;
    display: flex;
    flex-direction: column;
    align-items: center;
  }
  

  Hope my feedback helps you!, if you have any questions don't hesitate to ask

  0

  ---

  

  Divine•60

  @divine-engPosted about 2 years ago

  @DavidMorgade Thank you so much for your feedback...

  I will work towards I just started learning html and css with time I'll understand them.

  1

  

  David•8,000

  @DavidMorgadePosted about 2 years ago

  @divine-eng nice, keep it going with the learning and the challenges! you will get in the top in no-time!

  0