@Stroudy
Posted
Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…
-
Avoid using
idselectors for styling in CSS because they are too specific and hard to override, making your styles less flexible and maintainable. Instead, use class selectors (.), which are reusable and more manageable, allowing for better control over your styles and easier updates. -
Using a
<main>tag inside the<body>of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. -
Overusing
<div>tags, known as "divitis," leads to cluttered code, poor semantics, and reduced performance. Instead, use appropriate semantic elements (like<header>,<section>, etc.) to improve readability, accessibility, and SEO. Keep HTML clean and minimal to ensure maintainability, scalability, and better CSS structure.
<div id="qr-code">
<img src="images/image-qr-code.png" alt="qr-code">
</div>
-
For future project, You could download and host your own fonts using
@font-faceimproves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts -
Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset
-
While
pxis useful for precise, fixed sizing, such asborder-width,border-radius,inline-padding, and<img>sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, usingpxfor font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units likeremand adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Usepxwhere exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.
I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻
Marked as helpful
@Erikaestudar
Posted
@Stroudy Thank you very much for your feedback, it gave me a lot of insights to improve more, I confess that I was unsure about doing this challenge, because I didn't know how start it.
@Stroudy
Posted
Hey @Erikaestudar,
This is a great start! The most important thing is that you completed the challenge and are now receiving valuable feedback. Everyone's first steps in this industry are similar, so you're definitely not alone. I’ve been through the same process, and with persistence, my knowledge has grown—and yours will too. Keep going, take your time, and remember that progress comes one step at a time. You’ve got this!
Marked as helpful
