Design comparison
SolutionDesign
Solution retrospective
Hi everyone, here my solution from Frontend-Mentor-Four-card-feature-section-challenge-hub.
So, please, check my code.
I wish to have your feedbacks to improve my skills.
Happy coding !
Community feedback
- @kens-visualsPosted about 3 years ago
Hey @onmywayfromwestindies 👋🏻
I have some suggestions to help you fix the accessibility issues and some other things
- In your markup,
<div class="">...</div>
should be<main class="">...</main>
. This will fix the accessibility issues. Only, don't forget to generate a new repot once you fix the issues. - For the icons, add
aria-hidden="true”
, because they are for decoration. You can read more aboutaria-hidden
here. For example:
<img class="icon" src="./images/icon-supervisor.svg" alt="" aria-hidden="true”>
- Also, I suggest adding
transition: all 0.2s;
to the boxes, this will make their:hover
smoother. You'll see what I mean once you add them.
I hope this was helpful 👨🏻💻 Other than that, you did a great job, especially with responsiveness. Cheers 👾
Marked as helpful0 - In your markup,
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord