Responsive landing page using CSS flexbox
Design comparison
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi @GodstimeNwabue, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Document should have one main landmark, you could have put all the content inside the
main
tag click here2- Page should contain a level-one heading click here
3- When you are going to center a content, prefer to use
flex-box
instead ofmargin
You could have done it like this:body { justify-content: center; min height: 100vh; align-items: center; }
The rest is really good! Hope it helps... 👍
Marked as helpful1@GodstimeNwabuePosted about 2 years ago@AdrianoEscarabote Thanks so much, i really appreciate it. About to update it. Please any best practices of naming classes. Though i did understand BEM method. Is it okay to name it on how the project is given.
1@GodstimeNwabuePosted about 2 years ago@AdrianoEscarabote Thanks so much, i really appreciate it. About to update it. Please any best practices of naming classes. Though i did understand BEM method. Is it okay to name it on how the project is given.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord