Responsive landing page using CSS flexbox

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted about 2 years ago

  Hi @GodstimeNwabue, how are you?

  I really liked the result of your project, but I have some tips that I think you will like:

  1- Document should have one main landmark, you could have put all the content inside the main tag click here

  2- Page should contain a level-one heading click here

  3- When you are going to center a content, prefer to use flex-box instead of margin You could have done it like this:

  body { justify-content: center; min height: 100vh; align-items: center; }

  The rest is really good! Hope it helps... 👍

  Marked as helpful

  1

  ---

  

  Godstime Nwabue•150

  @GodstimeNwabuePosted about 2 years ago

  @AdrianoEscarabote Thanks so much, i really appreciate it. About to update it. Please any best practices of naming classes. Though i did understand BEM method. Is it okay to name it on how the project is given.

  1

  

  Godstime Nwabue•150

  @GodstimeNwabuePosted about 2 years ago

  @AdrianoEscarabote Thanks so much, i really appreciate it. About to update it. Please any best practices of naming classes. Though i did understand BEM method. Is it okay to name it on how the project is given.

  0