Responsive landing page using CSS Flex and JS

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 8 months ago

  Hey again @Xarlizard!

  Your solution looks impressive!

  I've got an idea (about how to use HTML better) that could make it even stronger:

  📌 Think about using <main> to wrap your main content instead of <div>.

  Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

  • And since the numbers and the submit button are clickable elements, it's nice to add cursor: pointer to them.

  📌 This gives the user a visual indication that the element is clickable, as obvious as it may look.

  • Also, you can add a validation to your javascript: If the user tries to submit without picking a number, you give them an alert("You must choose a number before submitting your rating."). Something like that.

  Hope that's helpful!

  Keep up the great work!

  Marked as helpful

  1
• 

  Charlie•300

  @XarlizardPosted 8 months ago

  Native nested CSS is not working properly until they upgrade the browser that runs on the background of frontendmentor for the showcases. It is working fine at my Github Page live version.

  0