Responsive landing page using CSS flex

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 3 months ago

  Hello, here is some feedback:

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • You don't need to wrap the image in a <div>, so I would remove that <div>.

  • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • Remove the height attribute on the <img>.

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I would add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove all widths and heights in px.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • Remove align-self: center, it is not needed.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • letter-spacing must also never be in px. You can use em, where 1em equals the element's font size.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • I would use px instead of % for border-radius.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container. Remove position: relative.

  • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px. Also, it is common practice to do mobile styles first and use media queries for larger screens.

  Good luck :)

  Marked as helpful

  1

  ---

  

  Anna_plaa•70

  @Happy-hacking777Posted 3 months ago

  @Islandstone89 Hi, Thank you very much for your feedback. Now I need some time to investigate CSS reset. It was new for me and after including it, the design was already different. This answer was overwhelming with useful information.

  1