Submitted almost 2 years ago

responsive landing page using CSS Flex

xmat• 160

@mati0165

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Community feedback

Melvin Aguilar 🧑🏻‍💻• 61,220

@MelvinAguilar

Posted almost 2 years ago

Hi @mati0165 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

Here are some suggestions you might consider:

Try to use semantic tags in your code. It should have the main tag that groups all of your card elements:

<body>
   <main class="card">
      . . .
   </main>
   <footer>
      . . .
   </footer>
<body>

Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
Use min-height: 100vh to body selector, with this property you set a height and let the element grow even more if necessary. Your elements will also be vertically centered when you use this property. Also, remove the margin: 217px; to center correctly.

I hope those tips will help you.

Good job, and happy coding!

Marked as helpful

バレンタイン 😈• 64,190

@VCarames

Posted almost 2 years ago

Hey there! 👋 Here are some suggestions to help improve your code:

The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
Change width to max-width: 100% in your image to make it responsive. You will also want to remove the height as it is unnecessary.
Remove all the text-align: center; you added repeatedly and only add it to your component's container.

If you have any questions or need further clarification, let me know.

Happy Coding! 👻🎃

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord