Responsive landing page use Flexbox and Vanilla JS

Community feedback

• 

  CyrusKabir•1,885

  @CyrusKabirPosted over 2 years ago

  Hello my dear friend ♥ you did good on this challenge and here some improvements for your component :

  • for decorative images or images that do not give specific information to the user it's better to use background-image for that and along properties like background-position , size,...
  • If I only want to work with your component with the keyboard (tab key), unfortunately I can't because of the use of non interactive element like <p> so using button here it's good for accessibility ( And I must say that in the last challenge that I did, I didn't pay attention to this issue and now that I saw your project, I remember so thanks 😄);
  • also you can wrap each related question and answer to a container and then add that border bottom to container but if you want use <hr> it's better to add these things to hr tag opacity: 1; width: 100%; border: 0px solid <color>; border-top-width: 1px;

  Marked as helpful

  2

  ---

  

  Mônica Aparecida Kerber Dalosto•100

  @MonicaDalostoPosted over 2 years ago

  @CyrusKabir Thank you! Your feedback was really helpful to improve my code. I took note of all your tips. Thanks again!

  1
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge

  Keep up the good work

  Your solution looks great however I think that the card needs a subtle box-shadow using box-shadow.

  I hope this helps

  Cheers Happy coding 👍

  1

  ---

  

  Mônica Aparecida Kerber Dalosto•100

  @MonicaDalostoPosted over 2 years ago

  @TheCoderGuru Thanks for your feedback! I've revised my code and realize that I've already had the box-shadow and, probably I'm using it in the wrong way. Thanks for enlighten me about this.

  0