Responsive landing page

Community feedback

• 

  P

  Øystein Håberg•10,490

  @Islandstone89Posted 11 months ago

  Hey, good work on the Summary Card. I'm not experienced in giving feedback on this challenge, but I wanted to give a few tips nonetheless - hope it helps :)

  HTML:

  • I think "Your Result" and "Summary" should be some sort of headings.

  • The icons are decorative, so the alt text should be empty: alt="".

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Font-size must never be in px. Use rem instead.

  • Remove the width and min-width on .container. If needed, add a max-width in rem.

  • Remove the fixed width and height. You rarely want to set fixed dimensions, as this easily creates issues with responsiveness.

  • Media queries should be in rem instead of px. Ideally, you want to do mobile styling first and use media queries for larger screens. Anyway, your max-width is too low, I would change it to maybe around 40rem, which equals to over 600px.

  Marked as helpful

  0
• 

  Dusan Simic•470

  @superstar119Posted 11 months ago

  I agree!

  0