Skip to content
Submitted over 1 year ago

Responsive landing page of product preview

Onyinyechi Viola Obika•130
@Obikaviola
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am proud that I was able to successfully use a tag that I haven't used before even when the tag was posing to be an issue. I was able to overcome the issue. The picture tag is what I'm talking about.

What challenges did you encounter, and how did you overcome them?

The challenge I had was setting up the images so that a particular image meant for mobile view shows and the other image appears for desktop screen size. I was able to overcome this using the picture tag which I highlighted in the README.md.

I also experienced another problem where the picture tag was giving extra space at the bottom and the top. I was able to overcome this using

picture{
     font-size: 0;
     width: 100%;

Community feedback

  • Hassia Issah•50,650
    @HassiaiPosted over 1 year ago

    Replace <div class="container"> with the main tag and the main tag with a section tag to fix the accessibility issues.

    The header tag should be within the section tag.

    <main>
<picture><img></picture>
<section>
<header>
 ... its content goes here
</header>
 ---- the rest of the content goes here
<button></button>
</section>
</main>

    Add the alt attribute alt=" " to the img tag and give it a value to fix the error issue. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.

    There is no need to give .container a margin value.

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    Marked as helpful
    1
    Onyinyechi Viola Obika•130
    @ObikaviolaPosted over 1 year ago

    @Hassiai Done. Thank you for the feedback

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord