Submitted almost 3 years ago
Responsive landing page of ecommerce- shoe store
@JiawenZhuo
Design comparison
SolutionDesign
Solution retrospective
Hello, this is my first react app with Styled-component. I am a little bit unsure about how to name each folder and the hierarchy of the folders. Any critical comment will be appreciate !
Community feedback
- @AkhilrajNambiarPosted almost 3 years ago
There are some issues in your report @JiawenZhuo . Here is what you could do to solve them:
- For accessibility issues:
- Add the alternate text for all images you use.
- Give the root element of your document a class name of 'main', or else a role of 'main'.
- For HTML issues:
- font-style should be replaced by font-weight, if you are trying to make the text bold.
- margin and padding cannot have value of none. Use 0 instead.
- flex-direction can only have values row, row-reverse, column, column-reverse. If you want to enable wrapping, use the flex-wrap attribute.
- border-color can only use colors(none is not a color!). If you don't want a border color, use transparent.
1@JiawenZhuoPosted almost 3 years ago@AkhilrajNambiar Very detailed and useful thanks Akhilraj !
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord