Submitted 6 months ago

Responsive landing page

MiJouHsieh•20

@MiJouHsieh

Preview site View code

This is a solution for...QR code component

HTML
CSS

1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I take pride in revisiting the fundamentals of positioning, responsive web design (RWD), and media queries, as it has deepened my understanding after implementation.
I utilized the :root property in CSS files to globally set colors. This served as a review exercise due to the simplicity of the project.
Next time, I plan to employ Sass syntax for CSS, leveraging its features to streamline and enhance my coding process.

What challenges did you encounter, and how did you overcome them?

There weren't significant difficulties, but I did have a momentary lapse in remembering which breakpoints to use within the media queries.

What specific areas of your project would you like help with?

Naming conventions for the markup and stylesheets.
Streamlining CSS code for improved efficiency.

Community feedback

Daniel 🛸•44,250
@danielmrz-devPosted 6 months ago
Hello there!

Congrats on completing the challenge! ✅

Your solution looks great!

I have a suggestion for improvement:

📌 Think about using <main> to wrap your main content instead of <div> You can wrap the whole thing with it, not only the text..

Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.

Hope that's helpful!

Keep up the great work!
0
gabriel 🍉•70
@eugabrieldesousaPosted 6 months ago
nice
0

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord