Responsive landing page (Mobile-First approach). Using ReactJS, SCSS.

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Greetings, Simon Hernandez! 👋

  Incredible work on this challenge! 🙌 It's great to see you back with another solution! 👏 I really like the animations you added to your solution! 😀

  A small suggestion I have is to perhaps set the alt text for the icons in the "Why choose Easybank?" section to be an empty string so that they will be ignored by screen readers. That’s because those elements aren't really necessary or important to the content of the page and as a result probably don't need to be read by screen readers. 😉

  It would also be good to add some focus styles to some of the interactive elements on the page that do not currently have them (such as the "Request invite" buttons).

  And it would be worth taking a look at the responsive issue that @veljkoilic mentioned in the hero section of the site! 🙂

  Hope you find this helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2

  ---

  

  Simon Hernandez•615

  @simonhernandezPosted over 2 years ago

  Hello, @ApplePieGiraffe!

  It is great to know about you again!

  Thanks so much for your feedback and suggestions. I took them into account and applied them on my solution. I also fixed the responsive issue @veljkoilic mentioned.

  Thanks again for your always helpful feedback!

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  @simonhernandez

  Of course! Happy to help! 😊

  0
• 

  Veljko Ilic•190

  @veljkoilicPosted over 2 years ago

  Awesome work dude!

  Everything looks super slick and responsive! I suggest you make your animations go only one way. If you scroll up and down again they replay, but this is just a personal taste.

  However, there is a bit of a weird 1000px - 1140px area. The Intro section heading overlaps with the background making it unreadable and the articles at the bottom are really squished. This is all minor but I thought you'd appreciate the nitpicking feedback!

  Marked as helpful

  1

  ---

  

  Simon Hernandez•615

  @simonhernandezPosted over 2 years ago

  @veljkoilic

  Hello Veljko!

  Thank you so much for your feedback!

  I don't know how I missed such an obvious issue in responsiveness. I took a look at it and fixed it so that the heading and background image don't overlap. Also fixed the squished articles by setting some gap between them.

  Thanks again for your helpful feedback on my solution. I really appreciate it!

  0