Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

responsive landing page media

Lynamara 10

@lynamara

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


how could i improve my code? I'm starting so I just used the basics

Community feedback

P

@davidFreelance19

Posted

Hello developer!

First I would like to congratulate you for completing this challenge! I have seen your code and I bring you some options to improve it:

body{
     display: flex;
     width: 100%;
     height: 100vh;
     position:relative;
     align-items: center;
     justify-content: center;
}
.cartao{
   edge: 0;
}
.conteudo{
   width: 90%;
   margin: 0 auto;
}
.attribution{
     position: absolute;
     bottom: 5%;
     right: 35%;
}

I would also like to give you some advice: -Do some research on what HTML grouping tags are (We don't always have to use <div></div> to group information)

-Better learn display flex and *display grid. This will help you generate a responsive design in a better way, since you will be using its positioning properties.

-Learn some methodology like BEM or Utilities

David Rodriguez

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord