Travolgi 🍕• 31,420
@denielden
Posted
Hello Mohammed, You have done a good work! 😁
Some little tips to improve your code:
- use
5rem
value to theheader .hero .cta .btn
class to fix theborder-radius
- remove all unnecessary code, the less you write the better as well as being clearer: for example the
figure
tag container of image - to use
picture
tag correctly to change image by resolution -> read here - to fix the position of the menu in the mobile set
top: 14rem
toheader nav.active
class - add
transition
on the element with hover effect - instead of using
px or %
use relative units of measurement likerem
-> read here
You have done good work with the semantic html tag like a header, footer and main :)
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
1
Dev saidAli• 400
@Dev-saeedAli
Posted
@denielden Thank you so much.
1
Travolgi 🍕• 31,420
@denielden
Posted
@Dev-saeedAli you are welcome and keep it up :)
1
Dev saidAli• 400
@Dev-saeedAli
Posted
@denielden updated.
1