@vanzasetia
Posted
Hi there! 👋
Good effort on this challenge! 👍
About the background image, I would recommend setting the size as 100%
and positioning it on the top
. I notice that you override the background
shorthand styling, specifically the background-size
and the background-position
which you don't need to do.
I used flexbox for the Annual Plan part or in this case, the order-item
however, you can use grid if you want. I would recommend choosing either grid or flexbox over absolute positioning.
Alternative text for images should not contain any words that related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image.
Also, the music icon is also a decorative image the same as the illustration. So, leave the alt
empty.
On mobile view, to be specific 360px * 640px. the buttons are overflowing from the card element. It's because of the width
that are specified on them.
That's it! I hope this information is useful! 😁
Marked as helpful
@MightyKale
Posted
@vanzasetia Thank you for your detailed advice, I will look into them and make modifications!
@vanzasetia
Posted
@MightyKale You're welcome! 😄
@MightyKale
Posted
@vanzasetia Hi, I made changes to everything you've addressed and it worked like a charm. I am especially amazed by how easy it is to set the background image just by changing the size to 100%. I changed the buttons to be responsive as well. Thank you so much again.
@vanzasetia
Posted
@MightyKale Your solution looks better now. The button is no longer overflowing from the card. Great job with the updates! 👍