Skip to content
Submitted over 1 year ago

Responsive landing page JUNIOR SASS HTML

RohyllerP•70
@RohyllerP
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...News homepage
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Community feedback

  • Ed-dyb Abdelilah•1,560
    @eddybproPosted over 1 year ago

    Hi, RohyllerP

    Congratulation on finishing this challenge, I hope it was fun.

    Here are some suggestions that might improve the code:

    • CSS code:
    .p-all{
margin: 0;
}

.main{
margin:0;
}

    Tips

    • Syntactically the main element is a semantic element and should be the container like that:
    <main>
<!- your code here->
</main>

    In general, the HTML file structure looks like that:

    <!DOCTYPE html>
<html lang="en">
<head>
</head>
<body>
<header></header>
<main></main>
<footer></footer>
</body>
</html>
    • It's not necessary to add units to the values that equal 0.

    e-g: margin: 0;

    • Remember to use relative units rem em instead of absolute units px.

    ALL DONE YOU DID A NICE JOB KEEP GOING

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord