Ed-dyb Abdelilah• 1,560
@eddybpro
Posted
Hi, RohyllerP
Congratulation on finishing this challenge, I hope it was fun.
Here are some suggestions that might improve the code:
- CSS code:
.p-all{
margin: 0;
}
.main{
margin:0;
}
Tips
- Syntactically the
mainelement is a semantic element and should be the container like that:
<main>
<!- your code here->
</main>
In general, the HTML file structure looks like that:
<!DOCTYPE html>
<html lang="en">
<head>
</head>
<body>
<header></header>
<main></main>
<footer></footer>
</body>
</html>
- It's not necessary to add units to the values that equal 0.
e-g: margin: 0;
- Remember to use relative units
rem eminstead of absolute unitspx.
ALL DONE YOU DID A NICE JOB KEEP GOING
0
