Vanza Setia• 27,795
@vanzasetia
Posted
Hi, Joshua Manansala! 👋
Congratulations on completing this challenge! 🎉
I have a few suggestions for this solution.
- The
aria-labelfor the social media links should not contain the word "link" since the anchor tags themselves are already enough. Right now, screenreaders might read them like, "link to instagram homepage, link." So, I would recommend keeping it as simple as possible by just telling the social media platform,aria-label="Instagram". - I notice some invalid BEM like
header__top-header__logo. You can't nest an element inside an element. It would make it as BEE (block__element__element) instead. So, I suggest renaming it toheader__logo. - I would recommend making all the buttons as link elements instead of button elements. I think if this is a real website, those buttons would navigate the users to a sign-up page (or something similar to that).
Hope this helps. 🙂
Marked as helpful
1
Joshua Manansala• 265
@T4R0TARO
Posted
@vanzasetia Thank you so much for your input! All your suggestions are very helpful and I will go ahead and make those corrections. I just started using BEM on my projects so this tip really clarified it for me. 🙏
0
Vanza Setia• 27,795
@vanzasetia
Posted
@T4R0TARO No problem! Glad you found it to be helpful! 😄
0
