Design comparison
Solution retrospective
What I found most difficult during this project was setting up the html structure that would be good for both mobile and desktop views.
I also struggled with deciding if I should use grid, flexbox or mashup of the 2 and finally decided on the latter. I'm not sure if this is the right approach though.
My design is not a 1:1 reproduction of the original, but I'm satisfied with how it looks now.
I'll be vary happy if you check it out and I'd appreciate any feedback!
Community feedback
- @Rhinozer0sPosted over 1 year ago
Hey Adriana,
i can see that you have implemented my
<picture>
advice. Only use the this tag when there is more than one source for the image.You can red more about it here: https://www.w3schools.com/tags/tag_picture.asp
Furthermore you could replace the
<nav>
-tag width a<header>
-tag. The nav is only to mark the menu for navigationI hope you find this helpfull. Otherwise your Code seems clean to me. Keep having fun.😎
Marked as helpful1@AdrianaMagdalenaPosted over 1 year agoHey!
Oh yes, I tend to overuse freshly learned stuff, thank you for correcting me on this again, I'll readup on it! Semantic tags are also still a bit unclear to me in some cases, so I'll correct the nav tag soon too.
Thank you again, I really appreciate you spending time on checking my code!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord