Responsive landing page for frontend mentor qr code component challeng
Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="container"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .qr-block on the page using flexbox or grid instead position: absolute, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
To center .qr-block on the page using flexbox: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
To center .qr-block on the page using grid: body{ min-height: 100vh; display: grid; place-items: center; }
There is no need to style .container on.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord