Design comparison
Solution retrospective
I haven't created the mobile friendly version.
First time writing my own javascript code, would also be keen to hear opinions on the structure of my CSS & class/ID names.
Thank you!
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here is some feedback to further improve your code:
- This element does not exist LINK so why use it❓
- Same for this one LINK.
- Every site should ALWAYS have ✅ a
main
element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serves as the component’s container ⚠️.
More Info: 📚
- Unfortunately, the HTML for the ratings needs to be rewritten as it was done incorrect ❌:
To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a
form
⚠️.- Everything will be wrapped inside a
fieldset
which will have alegend
that is visually hidden using CSS. - Inside, there should be five
input radios
and eachinput
should have alabel
attached to it to make the “ratings” accessible. - The last thing you will want to include will be a
button
so users can submit their choice.
Here is how it looks like fully implemented: EXAMPLE
- Once the top is implemented , for your JS, the
eventListener
should be on theform
⚠️ as asubmit
.
More Info:📚
Click vs. Submit EventListeners
After looking though your code, I definitely recommend you look up the HTML elements and read all the article I provided.
If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.
Happy Coding! 😈
Marked as helpful1@Callietron300Posted almost 2 years ago@vcarames thank you for the feedback, much appreciated :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord