Responsive landing page- first try

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here is some feedback to further improve your code:

  • This element does not exist LINK so why use it❓

  • Same for this one LINK.

  • Every site should ALWAYS have ✅ a main element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serves as the component’s container ⚠️.

  More Info: 📚

  MDN Main Element

  • Unfortunately, the HTML for the ratings needs to be rewritten as it was done incorrect ❌:

  To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a form ⚠️.

  1. Everything will be wrapped inside a fieldset which will have a legend that is visually hidden using CSS.
  2. Inside, there should be five input radios and each input should have a label attached to it to make the “ratings” accessible.
  3. The last thing you will want to include will be a button so users can submit their choice.

  Here is how it looks like fully implemented: EXAMPLE

  • Once the top is implemented , for your JS, the eventListener should be on the form ⚠️ as a submit.

  More Info:📚

  Click vs. Submit EventListeners

  After looking though your code, I definitely recommend you look up the HTML elements and read all the article I provided.

  If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  Happy Coding! 😈

  Marked as helpful

  1

  ---

  

  Callie•170

  @Callietron300Posted almost 2 years ago

  @vcarames thank you for the feedback, much appreciated :)

  1