Responsive landing page (CSS Grid/VueJS)

Community feedback

• 

  P

  Teodor Jenkler•3,740

  @TedJenklerPosted 2 months ago

  Hi @JamesLaviron,

  Nice project! Here are a few suggestions to enhance your work:

  Minimize <div> Usage: Try to reduce the use of <div> elements to improve accessibility and SEO. Many of your <div>s could be replaced with a parent element using display: flex and flex-direction: column to stack them vertically. This will help simplify your code and make it cleaner.

  Use Semantic Elements: While <section> and <article> are useful, overusing them can sometimes make your code less clean. Balance their use with more flexible layout approaches to keep your code tidy.

  Headings and Responsiveness: Good job with the headings and ensuring the project is responsive and visually appealing!

  Keep up the great work!

  Best, Teodor

  Marked as helpful

  0
• 

  Svitlana Suslenkova•5,320

  @SvitlanaSuslenkovaPosted 2 months ago

  It's better to add background-color to the body here, not to the main. Hope you found this comment helpful :)

  Marked as helpful

  0

  ---

  

  VictorGerfaud•210

  @JamesLavironPosted 2 months ago

  @SvitlanaSuslenkova Any feedback is great but can you explain why or give me a link?

  0

  

  Svitlana Suslenkova•5,320

  @SvitlanaSuslenkovaPosted 2 months ago

  @JamesLaviron your backgrond-color ends earlier then my screen (it's not 100vh), I have white stripe without background when I see your project

  1