Responsive landing page, CSS flexbox...

Community feedback

• 

  palharesmagnon•85

  @palharesmagnonPosted about 3 years ago

  Hello @annabelska. Your solution is really great. I'm a newbie too, but maybe I can give you some tips.

  1. The mobile-first strategy is the best approach to achieving a responsive layout and reducing code complexity
  2. It would be better to use semantic tags in the html. For example, you could use <article class="container"> instead of <div class="container">. Semantics
  3. It's a good idea to look for CSS design patterns and conventions. Like the BEM naming convention. This helps to better organize our codes and reduces the complexity of markup in the html file
  4. I really think it's time you gave your CSS super powers. There are some CSS preprocessors out there, but the most used is Sass
  5. It is very important that you start using relative rather than fixed units for your responsive design. That's it. Happy code

  Marked as helpful

  0
• 

  Aditya Raj Tripathi•70

  @Script-DPosted about 3 years ago

  Hi, Ana you've done it nicely but one thing I noticed is that there is no hover state for links in your design. It gives a sense of visual interaction so it would be great if you implement it. And also your SVG in background is not covering whole width, try using background-size: contain. Great work though

  Marked as helpful

  0