Design comparison
Community feedback
- @frank-itachiPosted almost 2 years ago
Hello there π. You did a good job!
I have some suggestions about your code that might interest you.
HTML π:
-
Wrap the page's whole main content in the
<main>
tag. -
If your code has different sections that have a specific purpose like a navigation, article, sections or footer, itβs a good practice to enclose those parts with HTML5 landmarks. For example, you could use a
<footer>
tag to wrap a footer section.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding π!
Marked as helpful2 -
- @HassiaiPosted almost 2 years ago
Replace<div class="container">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
Give h1 and p the same font-size of 15px which is 0.9375rem and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord