Responsive landing page created with React and SASS

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  The navigation list is not keyboard focusable , the list items must be anchor elements as their are supposed to other external pages. Having said that, you did an awesome job with responsiveness. Well done

  Marked as helpful

  1

  ---

  

  Hyun Don•105

  @hyundonnyPosted over 3 years ago

  Hello, @ChamuMutezva!

  I left the list items as li elements simply because they were pointing nowhere. I'm not 100% sure on this but I think they might cause an error if I simply left the src on the anchor element as "#". Again, not completely sure on this so I may just have made a mistake.

  In terms of the navigation list not being keyboard focusable, I must admit I didn't really think of that aspect of the website. I'm only a beginner so there's lots of stuff I missed haha. I'll look into how I can make things keyboard focusable.

  Thank you for your kind words! Have a wonderful day :)

  1

  

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  @hyundonny , thats a valid point there. I have seen some suggestion like the one below <a href="#" onClick="return false;"> . I normally want to include it just to keep with practices and that way on a real project i won't forget

  1