Responsive landing page by adding max-width

Hello Raul, congrats on completing this project. You shouldn’t you the html tag to set global styles like the font family, which should be set using a body tag. When setting font sizes, you should use em or rem units, not percents. Adding 100% to the main container is not doing anything because block elements already occupy all available space. For the paragraph you should not set a width, try adding padding to the right and the left instead.

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to incorrect usage of semantic markup, which causes lacking of landmark for a webpage

• So fix it by replacing the <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

• What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

• For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Hey Raul, looks nice, the only thing I would try to fix is some of the margin (specifically bottom margin on the image. Looks a like a little bit too much. Also, I am very new to working on actual projects and am a beginner to coding in general so I would love a second opinion on this, but your last p tag, you have set it to be displayed as inline block, which in this case I don't think you need to. Its default setting of just "block" should be suffice. Some extra code that I think you can get rid of :)