Submitted over 1 year ago
Responsive Landing Page built w/Vanilla CSS & JavaScript
@JaryCruz
Design comparison
SolutionDesign
Solution retrospective
I very much appreciate any feedback!
Community feedback
- @IkuewumiPosted over 1 year ago
Hi Jary👋. Really cool solution. Here are my suggestions on improving this:
This page generates an error about: Links must have discernible text. In this case the link's content is an icon, and you could fix this issue by adding a title attribute to the
<i>
element like -<a href="#"> <i title="twitter" class="fa-brands fa-twitter"></i> </a>
Also, I saw you didn't add the decorative shape on the hero section. The shape is just a rectangle / square with a curved side. You could add it like so:
hero { position: relative } hero::before { content: ""; position: absolute; inset: auto 0 0 auto; //shorthand for the top, right, bottom, left properties width: 300px;//arbitrary number height: 300px; //arbitrary number background: blue; border-bottom-left-radius: 4vmax;//arbitrary number }
Anyways, I hope this helps. Again, this solution is really cool. Don't hesitate to ask more questions and keep coding👍,
Ayobami
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord