Vanza Setia• 27,795
@vanzasetia
Posted
Hi Claire! 👋
Good job on finishing this challenge! 👏
I have some feedback on this solution:
- The
header
should only contain the logo. Theheader__content
should be asection
inside themain
landmark. It's commonly called as hero section. - I would recommend using CSS
background
properties to handle those hero images. - For any decorative images, each
img
tag should have emptyalt=""
andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images. In this case, all images inside thesection-identifier
and hero images are decorative only. - The alternative text for the logo should not contain any words that are related to image, such as logo, icon, picture, photo, etc. The company name itself is already enough. 🙂
- The last section of the page should not be a
footer
element. It should be asection
that lives inside themain
landmark.footer
should contain information like copyright, etc.
That's it! Hopefully, this is helpful and happy coding! 😉
1
P
Claire Calder• 310
@claire-ca
Posted
@vanzasetia Hi Vanza!
Thank you so much for your feedback 🎉, it's been very helpful.
Happy coding!
1
Vanza Setia• 27,795
@vanzasetia
Posted
@claire-ca You're welcome! 👍
0