Responsive landing page built with Flexbox, Grid, SASS and BEM

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi Claire! 👋

  Good job on finishing this challenge! 👏

  I have some feedback on this solution:

  • The header should only contain the logo. The header__content should be a section inside the main landmark. It's commonly called as hero section.
  • I would recommend using CSS background properties to handle those hero images.
  • For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images. In this case, all images inside the section-identifier and hero images are decorative only.
  • The alternative text for the logo should not contain any words that are related to image, such as logo, icon, picture, photo, etc. The company name itself is already enough. 🙂
  • The last section of the page should not be a footer element. It should be a section that lives inside the main landmark. footer should contain information like copyright, etc.

  That's it! Hopefully, this is helpful and happy coding! 😉

  1

  ---

  

  P

  Claire Calder•310

  @claire-caPosted over 2 years ago

  @vanzasetia Hi Vanza!

  Thank you so much for your feedback 🎉, it's been very helpful.

  Happy coding!

  1

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @claire-ca You're welcome! 👍

  0